test(blockifier): uncover an error in test_l1_handler in the case of transaction version three #2146
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
This change is |
|
Artifacts upload triggered. View details here |
|
Artifacts upload triggered. View details here |
|
Benchmark movements: |
ArniStarkware
force-pushed
the
arni/test_utils/l1_handler/dedup_util
branch
from
3f82a9f
to
d48cc06
Compare
ArniStarkware
force-pushed
the
arni/tests/l1_handler/version_specific_error
branch
from
bcaf5fe
to
98dba2f
Compare
|
Artifacts upload triggered. View details here |
ArniStarkware
force-pushed
the
arni/test_utils/l1_handler/dedup_util
branch
from
d48cc06
to
8b70d13
Compare
ArniStarkware
force-pushed
the
arni/tests/l1_handler/version_specific_error
branch
from
98dba2f
to
65d1f92
Compare
|
Artifacts upload triggered. View details here |
ArniStarkware
changed the base branch from
arni/test_utils/l1_handler/dedup_util
to
graphite-base/2146
ArniStarkware
force-pushed
the
arni/tests/l1_handler/version_specific_error
branch
from
65d1f92
to
a01881b
Compare
ArniStarkware
force-pushed
the
graphite-base/2146
branch
from
8b70d13
to
5203a58
Compare
…transaction version three
ArniStarkware
force-pushed
the
arni/tests/l1_handler/version_specific_error
branch
from
a01881b
to
dc6bece
Compare
|
Artifacts upload triggered. View details here |
|
Artifacts upload triggered. View details here |
|
Artifacts upload triggered. View details here |
|
Artifacts upload triggered. View details here |
|
Artifacts upload triggered. View details here |
There was a problem hiding this comment.
Reviewed 1 of 2 files at r2.
Reviewable status: 1 of 4 files reviewed, all discussions resolved (waiting on @giladchase and @meship-starkware)
The test
test_l1_handlerfails for:use_kzg_da = trueandversion = TransactionVersion::THREE.I am unsure if it is supposed to pass - but the test fails only on incorrect
actual_fee == expected_actual_feein the last assertion of the test.Please tell me if it is acceptable for this test to fail and if we should avoid this flow - or if we should keep this test - and in that case - fix it or fix the code.